llvm.org GIT mirror llvm / e77b40b
Merging r278268: ------------------------------------------------------------------------ r278268 | nhaehnle | 2016-08-10 11:51:14 -0700 (Wed, 10 Aug 2016) | 28 lines LiveIntervalAnalysis: fix a crash in repairOldRegInRange Summary: See the new test case for one that was (non-deterministically) crashing on trunk and deterministically hit the assertion that I added in D23302. Basically, the machine function contains a sequence DS_WRITE_B32 %vreg4, %vreg14:sub0, ... DS_WRITE_B32 %vreg4, %vreg14:sub0, ... %vreg14:sub1<def> = COPY %vreg14:sub0 and SILoadStoreOptimizer::mergeWrite2Pair merges the two DS_WRITE_B32 instructions into one before calling repairIntervalsInRange. Now repairIntervalsInRange wants to repair %vreg14, in particular, and ends up trying to repair %vreg14:sub1 as well, but that only becomes active _after_ the range that is to be repaired, hence the crash due to LR.find(...) == LR.begin() at the start of repairOldRegInRange. I believe that just skipping those subrange is fine, but again, not too familiar with that code. Reviewers: MatzeB, kparzysz, tstellarAMD Subscribers: llvm-commits, MatzeB Differential Revision: https://reviews.llvm.org/D23303 ------------------------------------------------------------------------ git-svn-id: https://llvm.org/svn/llvm-project/llvm/branches/release_39@288454 91177308-0d34-0410-b5e6-96231b3b80d8 Tom Stellard 2 years ago
2 changed file(s) with 41 addition(s) and 0 deletion(s). Raw diff Collapse all Expand all
13931393 LaneBitmask LaneMask) {
13941394 LiveInterval::iterator LII = LR.find(endIdx);
13951395 SlotIndex lastUseIdx;
1396 if (LII == LR.begin()) {
1397 // This happens when the function is called for a subregister that only
1398 // occurs _after_ the range that is to be repaired.
1399 return;
1400 }
13961401 if (LII != LR.end() && LII->start < endIdx)
13971402 lastUseIdx = LII->end;
13981403 else
0 ; RUN: llc -march=amdgcn -mcpu=verde -verify-machineinstrs < %s | FileCheck %s
1 ; RUN: llc -march=amdgcn -mcpu=tonga -verify-machineinstrs < %s | FileCheck %s
2
3 ; This is used to crash in LiveIntervalAnalysis via SILoadStoreOptimizer
4 ; while fixing up the merge of two ds_write instructions.
5
6 @tess_lds = external addrspace(3) global [8192 x i32]
7
8 ; CHECK-LABEL: {{^}}main:
9 ; CHECK: ds_write2_b32
10 ; CHECK: v_mov_b32_e32 v1, v0
11 ; CHECK: tbuffer_store_format_xyzw v[0:3],
12 define amdgpu_vs void @main(i32 inreg %arg) {
13 main_body:
14 %tmp = load float, float addrspace(3)* undef, align 4
15 %tmp1 = load float, float addrspace(3)* undef, align 4
16 store float %tmp, float addrspace(3)* null, align 4
17 %tmp2 = bitcast float %tmp to i32
18 %tmp3 = add nuw nsw i32 0, 1
19 %tmp4 = zext i32 %tmp3 to i64
20 %tmp5 = getelementptr [8192 x i32], [8192 x i32] addrspace(3)* @tess_lds, i64 0, i64 %tmp4
21 %tmp6 = bitcast i32 addrspace(3)* %tmp5 to float addrspace(3)*
22 store float %tmp1, float addrspace(3)* %tmp6, align 4
23 %tmp7 = bitcast float %tmp1 to i32
24 %tmp8 = insertelement <4 x i32> undef, i32 %tmp2, i32 0
25 %tmp9 = insertelement <4 x i32> %tmp8, i32 %tmp7, i32 1
26 %tmp10 = insertelement <4 x i32> %tmp9, i32 undef, i32 2
27 %tmp11 = insertelement <4 x i32> %tmp10, i32 undef, i32 3
28 call void @llvm.SI.tbuffer.store.v4i32(<16 x i8> undef, <4 x i32> %tmp11, i32 4, i32 undef, i32 %arg, i32 0, i32 14, i32 4, i32 1, i32 0, i32 1, i32 1, i32 0)
29 ret void
30 }
31
32 ; Function Attrs: nounwind
33 declare void @llvm.SI.tbuffer.store.v4i32(<16 x i8>, <4 x i32>, i32, i32, i32, i32, i32, i32, i32, i32, i32, i32, i32) #0
34
35 attributes #0 = { nounwind }