llvm.org GIT mirror llvm / e092157
Merging r245862: ------------------------------------------------------------------------ r245862 | wschmidt | 2015-08-24 15:27:27 -0400 (Mon, 24 Aug 2015) | 8 lines [PPC64LE] Fix PR24546 - Swap optimization and debug values This patch fixes PR24546, which demonstrates a segfault during the VSX swap removal pass. The problem is that debug value instructions were not excluded from the list of instructions to be analyzed for webs of related computation. I've added the test case from the PR as a crash test in test/CodeGen/PowerPC. ------------------------------------------------------------------------ git-svn-id: https://llvm.org/svn/llvm-project/llvm/branches/release_37@252850 91177308-0d34-0410-b5e6-96231b3b80d8 Tom Stellard 3 years ago
2 changed file(s) with 119 addition(s) and 0 deletion(s). Raw diff Collapse all Expand all
238238
239239 for (MachineBasicBlock &MBB : *MF) {
240240 for (MachineInstr &MI : MBB) {
241
242 if (MI.isDebugValue())
243 continue;
241244
242245 bool RelevantInstr = false;
243246 bool Partial = false;
0 ; RUN: llc -mcpu=pwr8 -mtriple=powerpc64le-unknown-linux-gnu < %s
1
2 ; Verify that we no longer crash in VSX swap removal when debug values
3 ; are in the code stream.
4
5 @php_intpow10.powers = external unnamed_addr constant [23 x double], align 8
6
7 ; Function Attrs: nounwind
8 define double @_php_math_round(double %value, i32 signext %places, i32 signext %mode) #0 {
9 entry:
10 br i1 undef, label %if.then, label %if.else, !dbg !32
11
12 if.then: ; preds = %entry
13 %conv = sitofp i32 undef to double, !dbg !34
14 br i1 undef, label %if.then.i, label %if.end.i, !dbg !36
15
16 if.then.i: ; preds = %if.then
17 %call.i = tail call double @pow(double 1.000000e+01, double undef) #3, !dbg !39
18 br label %php_intpow10.exit, !dbg !41
19
20 if.end.i: ; preds = %if.then
21 %0 = load double, double* undef, align 8, !dbg !42, !tbaa !43
22 br label %php_intpow10.exit, !dbg !47
23
24 php_intpow10.exit: ; preds = %if.end.i, %if.then.i
25 %retval.0.i = phi double [ %call.i, %if.then.i ], [ %0, %if.end.i ], !dbg !48
26 tail call void @llvm.dbg.value(metadata double %retval.0.i, i64 0, metadata !15, metadata !49), !dbg !50
27 %div = fdiv double %conv, %retval.0.i, !dbg !51
28 br label %if.end.15, !dbg !52
29
30 if.else: ; preds = %entry
31 %mul = fmul double %value, undef, !dbg !53
32 br label %if.end.15
33
34 if.end.15: ; preds = %if.else, %php_intpow10.exit
35 %tmp_value.1 = phi double [ %div, %php_intpow10.exit ], [ %mul, %if.else ]
36 ret double %tmp_value.1, !dbg !57
37 }
38
39 declare signext i32 @php_intlog10abs(...) #1
40
41 declare signext i32 @php_round_helper(...) #1
42
43 ; Function Attrs: nounwind
44 declare double @pow(double, double) #0
45
46 ; Function Attrs: nounwind readnone
47 declare void @llvm.dbg.value(metadata, i64, metadata, metadata) #2
48
49 attributes #0 = { nounwind "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="ppc64le" "target-features"="+altivec,+bpermd,+crypto,+direct-move,+extdiv,+power8-vector,+vsx,-qpx" "unsafe-fp-math"="false" "use-soft-float"="false" }
50 attributes #1 = { "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="ppc64le" "target-features"="+altivec,+bpermd,+crypto,+direct-move,+extdiv,+power8-vector,+vsx,-qpx" "unsafe-fp-math"="false" "use-soft-float"="false" }
51 attributes #2 = { nounwind readnone }
52 attributes #3 = { nounwind }
53
54 !llvm.dbg.cu = !{!0}
55 !llvm.module.flags = !{!29, !30}
56 !llvm.ident = !{!31}
57
58 !0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, producer: "clang version 3.8.0 (git://github.com/llvm-mirror/clang.git e0848b6353721eb1b278a5bbea257bbf6316251e) (git://github.com/llvm-mirror/llvm.git 8724a428dfd5e78d7865bb01783708e83f9ed128)", isOptimized: true, runtimeVersion: 0, emissionKind: 1, enums: !2, retainedTypes: !3, subprograms: !5, globals: !23)
59 !1 = !DIFile(filename: "testcase.i", directory: "/tmp/glibc.build")
60 !2 = !{}
61 !3 = !{!4}
62 !4 = !DIBasicType(name: "double", size: 64, align: 64, encoding: DW_ATE_float)
63 !5 = !{!6, !18}
64 !6 = !DISubprogram(name: "_php_math_round", scope: !1, file: !1, line: 15, type: !7, isLocal: false, isDefinition: true, scopeLine: 16, flags: DIFlagPrototyped, isOptimized: true, function: double (double, i32, i32)* @_php_math_round, variables: !10)
65 !7 = !DISubroutineType(types: !8)
66 !8 = !{!4, !4, !9, !9}
67 !9 = !DIBasicType(name: "int", size: 32, align: 32, encoding: DW_ATE_signed)
68 !10 = !{!11, !12, !13, !14, !15, !16, !17}
69 !11 = !DILocalVariable(tag: DW_TAG_arg_variable, name: "value", arg: 1, scope: !6, file: !1, line: 15, type: !4)
70 !12 = !DILocalVariable(tag: DW_TAG_arg_variable, name: "places", arg: 2, scope: !6, file: !1, line: 15, type: !9)
71 !13 = !DILocalVariable(tag: DW_TAG_arg_variable, name: "mode", arg: 3, scope: !6, file: !1, line: 15, type: !9)
72 !14 = !DILocalVariable(tag: DW_TAG_auto_variable, name: "f1", scope: !6, file: !1, line: 17, type: !4)
73 !15 = !DILocalVariable(tag: DW_TAG_auto_variable, name: "f2", scope: !6, file: !1, line: 17, type: !4)
74 !16 = !DILocalVariable(tag: DW_TAG_auto_variable, name: "tmp_value", scope: !6, file: !1, line: 18, type: !4)
75 !17 = !DILocalVariable(tag: DW_TAG_auto_variable, name: "precision_places", scope: !6, file: !1, line: 19, type: !9)
76 !18 = !DISubprogram(name: "php_intpow10", scope: !1, file: !1, line: 1, type: !19, isLocal: true, isDefinition: true, scopeLine: 2, flags: DIFlagPrototyped, isOptimized: true, variables: !21)
77 !19 = !DISubroutineType(types: !20)
78 !20 = !{!4, !9}
79 !21 = !{!22}
80 !22 = !DILocalVariable(tag: DW_TAG_auto_variable, name: "power", arg: 1, scope: !18, file: !1, line: 1, type: !9)
81 !23 = !{!24}
82 !24 = !DIGlobalVariable(name: "powers", scope: !18, file: !1, line: 3, type: !25, isLocal: true, isDefinition: true, variable: [23 x double]* @php_intpow10.powers)
83 !25 = !DICompositeType(tag: DW_TAG_array_type, baseType: !26, size: 1472, align: 64, elements: !27)
84 !26 = !DIDerivedType(tag: DW_TAG_const_type, baseType: !4)
85 !27 = !{!28}
86 !28 = !DISubrange(count: 23)
87 !29 = !{i32 2, !"Dwarf Version", i32 4}
88 !30 = !{i32 2, !"Debug Info Version", i32 3}
89 !31 = !{!"clang version 3.8.0 (git://github.com/llvm-mirror/clang.git e0848b6353721eb1b278a5bbea257bbf6316251e) (git://github.com/llvm-mirror/llvm.git 8724a428dfd5e78d7865bb01783708e83f9ed128)"}
90 !32 = !DILocation(line: 21, column: 32, scope: !33)
91 !33 = distinct !DILexicalBlock(scope: !6, file: !1, line: 21, column: 6)
92 !34 = !DILocation(line: 22, column: 15, scope: !35)
93 !35 = distinct !DILexicalBlock(scope: !33, file: !1, line: 21, column: 67)
94 !36 = !DILocation(line: 8, column: 16, scope: !37, inlinedAt: !38)
95 !37 = distinct !DILexicalBlock(scope: !18, file: !1, line: 8, column: 6)
96 !38 = distinct !DILocation(line: 23, column: 8, scope: !35)
97 !39 = !DILocation(line: 9, column: 10, scope: !40, inlinedAt: !38)
98 !40 = distinct !DILexicalBlock(scope: !37, file: !1, line: 8, column: 31)
99 !41 = !DILocation(line: 9, column: 3, scope: !40, inlinedAt: !38)
100 !42 = !DILocation(line: 11, column: 9, scope: !18, inlinedAt: !38)
101 !43 = !{!44, !44, i64 0}
102 !44 = !{!"double", !45, i64 0}
103 !45 = !{!"omnipotent char", !46, i64 0}
104 !46 = !{!"Simple C/C++ TBAA"}
105 !47 = !DILocation(line: 11, column: 2, scope: !18, inlinedAt: !38)
106 !48 = !DILocation(line: 23, column: 8, scope: !35)
107 !49 = !DIExpression()
108 !50 = !DILocation(line: 17, column: 13, scope: !6)
109 !51 = !DILocation(line: 24, column: 25, scope: !35)
110 !52 = !DILocation(line: 25, column: 2, scope: !35)
111 !53 = !DILocation(line: 27, column: 22, scope: !54)
112 !54 = distinct !DILexicalBlock(scope: !55, file: !1, line: 26, column: 20)
113 !55 = distinct !DILexicalBlock(scope: !56, file: !1, line: 26, column: 7)
114 !56 = distinct !DILexicalBlock(scope: !33, file: !1, line: 25, column: 9)
115 !57 = !DILocation(line: 32, column: 2, scope: !6)