llvm.org GIT mirror llvm / add267e
[libcxxabi] Don't use -fvisibility-global-new-delete-hidden when not defining them When builing the hermetic static library, the compiler switch -fvisibility-global-new-delete-hidden is necessary to get the new and delete operator definitions made correctly. However, when those definitions are not included in the library, then this switch does harm. With lld (though not all linkers) setting STV_HIDDEN on SHN_UNDEF symbols makes it an error to leave them undefined or defined via dynamic linking that should generate PLTs for -shared linking (lld makes this a hard error even without -z defs). Though leaving the symbols undefined would usually work in practice if the linker were to allow it (and the user didn't pass -z defs), this actually indicates a real problem that could bite some target configurations more subtly at runtime. For example, x86-32 ELF -fpic code generation uses hidden visibility on declarations in the caller's scope as a signal that the call will never be resolved to a PLT entry and so doesn't have to meet the special ABI requirements for PLT calls (setting %ebx). Since these functions might actually be resolved to PLT entries at link time (we don't know what the user is linking in when the hermetic library doesn't provide all the symbols itself), it's not safe for the compiler to treat their declarations at call sites as having hidden visibility. Differential Revision: https://reviews.llvm.org/D61572 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@360004 91177308-0d34-0410-b5e6-96231b3b80d8 Petr Hosek 5 months ago
1 changed file(s) with 3 addition(s) and 1 deletion(s). Raw diff Collapse all Expand all
115115 public = cxxabi_headers
116116 if (libcxxabi_hermetic_static_library) {
117117 cflags = [ "-fvisibility=hidden" ]
118 cflags_cc = [ "-fvisibility-global-new-delete-hidden" ]
118 if (libcxxabi_enable_new_delete_definitions) {
119 cflags_cc = [ "-fvisibility-global-new-delete-hidden" ]
120 }
119121 defines = [