llvm.org GIT mirror llvm / 7369201
[CMake] Remove `CMAKE_.*_OUTPUT_DIRECTORY` (NFCI) Summary: Three `CMAKE_.*_OUTPUT_DIRECTORY` variables used to be set in CMake and referenced in various other parts of the project. However, in r198205 chapuni added a note to "don't set them anymore", and any remaining references to them were subsequently removed in r198316 and r199592. Now that the variables are no longer used anywhere, remove them, along with the comments advising against using them any longer. Test Plan: I ran `check-all` and confirmed the tests built and passed. Reviewers: beanz, chapuni Reviewed By: beanz Subscribers: mgorny Differential Revision: https://reviews.llvm.org/D38389 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@314550 91177308-0d34-0410-b5e6-96231b3b80d8 Brian Gesiak 2 years ago
2 changed file(s) with 0 addition(s) and 8 deletion(s). Raw diff Collapse all Expand all
760760 COMMAND cpack -G TGZ --config CPackSourceConfig.cmake -B ${LLVM_SRPM_DIR}/SOURCES
761761 COMMAND rpmbuild -bs --define '_topdir ${LLVM_SRPM_DIR}' ${LLVM_SRPM_BINARY_SPECFILE})
762762
763
764 # They are not referenced. See set_output_directory().
765 set( CMAKE_RUNTIME_OUTPUT_DIRECTORY ${LLVM_BINARY_DIR}/bin )
766 set( CMAKE_LIBRARY_OUTPUT_DIRECTORY ${LLVM_BINARY_DIR}/lib${LLVM_LIBDIR_SUFFIX} )
767 set( CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${LLVM_BINARY_DIR}/lib${LLVM_LIBDIR_SUFFIX} )
768
769763 if(APPLE AND DARWIN_LTO_LIBRARY)
770764 set(CMAKE_EXE_LINKER_FLAGS
771765 "${CMAKE_EXE_LINKER_FLAGS} -Wl,-lto_library -Wl,${DARWIN_LTO_LIBRARY}")
213213 endfunction(add_link_opts)
214214
215215 # Set each output directory according to ${CMAKE_CONFIGURATION_TYPES}.
216 # Note: Don't set variables CMAKE_*_OUTPUT_DIRECTORY any more,
217 # or a certain builder, for eaxample, msbuild.exe, would be confused.
218216 function(set_output_directory target)
219217 cmake_parse_arguments(ARG "" "BINARY_DIR;LIBRARY_DIR" "" ${ARGN})
220218