llvm.org GIT mirror llvm / 604ad96
How to close a review manually. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@257180 91177308-0d34-0410-b5e6-96231b3b80d8 Paul Robinson 3 years ago
1 changed file(s) with 7 addition(s) and 1 deletion(s). Raw diff Collapse all Expand all
135135 arc commit --revision D
138 When committing an LLVM change that has been reviewed using
138 When committing a change that has been reviewed using
139139 Phabricator, the convention is for the commit message to end with the
140140 line:
151151 This allows people reading the version history to see the review for
152152 context. This also allows Phabricator to detect the commit, close the
153153 review, and add a link from the review to the commit.
155 If you use ``git`` or ``svn`` to commit the change and forget to add the line
156 to your commit message, you should close the review manually. In the web UI,
157 under "Leap Into Action" put the SVN revision number in the Comment, set the
158 Action to "Close Revision" and click Submit. Note the review must have been
159 Accepted first.
155161 Abandoning a change
156162 -------------------