llvm.org GIT mirror llvm / 57b4c5d
[X86] Add a test case for r208252. Prior to r208252, the FMA 231 family was marked as isCommutable. However the memory variants of this family are not commutable. Therefore, we did not implemented the findCommutedOpIndices for those variants and missed that the default implementation (more or less: commute indices 1 and 2) was firing behind our back. As a result, as demonstrated in the test case before the fix, we were transforming a = b * c + a into a = a * c + b. I.e., before r208252 we were generating for this test case: vmovaps %xmm0, %xmm1 vmoss (%rsi), %xmm0 vfmadd231ss (%rdi), %xmm1, %xmm0 Instead of: vmoss (%rsi), %xmm1 vfmadd231ss (%rdi), %xmm1, %xmm0 <rdar://problem/16800495> git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@208260 91177308-0d34-0410-b5e6-96231b3b80d8 Quentin Colombet 6 years ago
1 changed file(s) with 30 addition(s) and 0 deletion(s). Raw diff Collapse all Expand all
0 ; RUN: llc -fp-contract=fast -mattr=+fma -disable-cgp < %s -o - | FileCheck %s
1 ; Check that the 2nd and 3rd arguments of fmaXXX231 reg1, reg2, mem3 are not commuted.
2 ;
3 target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
4 target triple = "x86_64-apple-macosx"
5
6 ; CHECK-LABEL: test1:
7 ; %arg lives in xmm0 and it shouldn't be redefined until it is used in the FMA.
8 ; CHECK-NOT {{.*}}, %xmm0
9 ; %addr lives in rdi.
10 ; %addr2 lives in rsi.
11 ; CHECK: vmovss (%rsi), [[ADDR2:%xmm[0-9]+]]
12 ; The assembly syntax is in the reverse order.
13 ; CHECK: vfmadd231ss (%rdi), [[ADDR2]], %xmm0
14 define void @test1(float* %addr, float* %addr2, float %arg) {
15 entry:
16 br label %loop
17
18 loop:
19 %sum0 = phi float [ %fma, %loop ], [ %arg, %entry ]
20 %addrVal = load float* %addr, align 4
21 %addr2Val = load float* %addr2, align 4
22 %fmul = fmul float %addrVal, %addr2Val
23 %fma = fadd float %sum0, %fmul
24 br i1 true, label %exit, label %loop
25
26 exit:
27 store float %fma, float* %addr, align 4
28 ret void
29 }