llvm.org GIT mirror llvm / 57965ba
[unittests][Support] Fix LLVM-Unit :: Support/./SupportTests/FileSystemTest.permissions on Solaris LLVM-Unit :: Support/./SupportTests/FileSystemTest.permissions currently FAILs on Solaris: FAIL: LLVM-Unit :: Support/./SupportTests/FileSystemTest.permissions (2940 of 51555) ******************** TEST 'LLVM-Unit :: Support/./SupportTests/FileSystemTest.permissions' FAILED ******************** Note: Google Test filter = FileSystemTest.permissions [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from FileSystemTest [ RUN ] FileSystemTest.permissions /opt/llvm-buildbot/obj/llvm/llvm.src/unittests/Support/Path.cpp:1705: Failure Value of: CheckPermissions(fs::sticky_bit) Actual: false Expected: true /opt/llvm-buildbot/obj/llvm/llvm.src/unittests/Support/Path.cpp:1712: Failure Value of: CheckPermissions(fs::set_uid_on_exe | fs::set_gid_on_exe | fs::sticky_bit) Actual: false Expected: true /opt/llvm-buildbot/obj/llvm/llvm.src/unittests/Support/Path.cpp:1719: Failure Value of: CheckPermissions(fs::all_read | fs::set_uid_on_exe | fs::set_gid_on_exe | fs::sticky_bit) Actual: false Expected: true /opt/llvm-buildbot/obj/llvm/llvm.src/unittests/Support/Path.cpp:1722: Failure Value of: CheckPermissions(fs::all_perms) Actual: false Expected: true [ FAILED ] FileSystemTest.permissions (0 ms) [----------] 1 test from FileSystemTest (0 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (1 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] FileSystemTest.permissions 1 FAILED TEST Checking with truss reveals that this is the same issue as on AIX and documented in chmod(2): If the process is not a privileged process and the file is not a direc- tory, mode bit 01000 (S_ISVTX, the sticky bit) is cleared. The following patch fixes this in the same way. Tested on amd64-pc-solaris2.11. Differential Revision: https://reviews.llvm.org/D63598 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@364671 91177308-0d34-0410-b5e6-96231b3b80d8 Rainer Orth 3 months ago
1 changed file(s) with 3 addition(s) and 2 deletion(s). Raw diff Collapse all Expand all
17501750 EXPECT_TRUE(CheckPermissions(fs::set_gid_on_exe));
17511751
17521752 // Modern BSDs require root to set the sticky bit on files.
1753 // AIX without root will mask off (i.e., lose) the sticky bit on files.
1753 // AIX and Solaris without root will mask off (i.e., lose) the sticky bit
1754 // on files.
17541755 #if !defined(__FreeBSD__) && !defined(__NetBSD__) && !defined(__OpenBSD__) && \
1755 !defined(_AIX)
1756 !defined(_AIX) && !(defined(__sun__) && defined(__svr4__))
17561757 EXPECT_EQ(fs::setPermissions(TempPath, fs::sticky_bit), NoError);
17571758 EXPECT_TRUE(CheckPermissions(fs::sticky_bit));
17581759