llvm.org GIT mirror llvm / 5348496
Mark tADDrSPi as having side effects again. It really doesn't, but when r141929 removed the hasSideEffects flag from this instruction, it caused miscompilations. I am guessing that it got moved across a stack pointer update. Also clear isRematerializable after checking that this instruction is in fact never rematerialized in the nightly test suite. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@142030 91177308-0d34-0410-b5e6-96231b3b80d8 Jakob Stoklund Olesen 8 years ago
1 changed file(s) with 3 addition(s) and 3 deletion(s). Raw diff Collapse all Expand all
309309 }
311311 // ADD , sp, #
312 // This is rematerializable, which is particularly useful for taking the
313 // address of locals.
314 let isReMaterializable = 1, neverHasSideEffects = 1 in
312 // FIXME: This should not be marked as having side effects, and it should be
313 // rematerializable. Clearing the side effect bit causes miscompilations,
314 // probably because the instruction can be moved around.
315315 def tADDrSPi : T1pI<(outs tGPR:$dst), (ins GPRsp:$sp, t_imm0_1020s4:$imm),
316316 IIC_iALUi, "add", "\t$dst, $sp, $imm", []>,
317317 T1Encoding<{1,0,1,0,1,?}> {