llvm.org GIT mirror llvm / 4572996
Merging r353155: ------------------------------------------------------------------------ r353155 | hans | 2019-02-05 12:01:54 +0100 (Tue, 05 Feb 2019) | 11 lines Fix format string in bindings/go/llvm/ir_test.go (PR40561) The test started failing for me recently. I don't see any changes around this code, so maybe it's my local go version that changed or something. The error seems real to me: we're trying to print an Attribute with %d. The test talks about "attribute masks" I'm not sure what that refers to, but I suppose we could print the raw pointer value, since that's what the test seems to be comparing. Differential revision: https://reviews.llvm.org/D57672 ------------------------------------------------------------------------ git-svn-id: https://llvm.org/svn/llvm-project/llvm/branches/release_80@353279 91177308-0d34-0410-b5e6-96231b3b80d8 Hans Wennborg 8 months ago
1 changed file(s) with 2 addition(s) and 2 deletion(s). Raw diff Collapse all Expand all
3030 fn.AddFunctionAttr(attr)
3131 newattr := fn.GetEnumFunctionAttribute(kind)
3232 if attr != newattr {
33 t.Errorf("got attribute mask %d, want %d", newattr, attr)
33 t.Errorf("got attribute %p, want %p", newattr.C, attr.C)
3434 }
3535
3636 text := mod.String()
4141 fn.RemoveEnumFunctionAttribute(kind)
4242 newattr = fn.GetEnumFunctionAttribute(kind)
4343 if !newattr.IsNil() {
44 t.Errorf("got attribute mask %d, want 0", newattr)
44 t.Errorf("got attribute %p, want 0", newattr.C)
4545 }
4646 }
4747