llvm.org GIT mirror llvm / 440ef85
Add a note about using "Differential Revision:" in commit messages I noticed this convention from the commit logs. It seems like it would be useful to document it, to encourage other committers to link back to code reviews in their commits. Differential Revision: http://llvm-reviews.chandlerc.com/D2678 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@201160 91177308-0d34-0410-b5e6-96231b3b80d8 Mark Seaborn 5 years ago
1 changed file(s) with 20 addition(s) and 0 deletion(s). Raw diff Collapse all Expand all
9393 the web interface. Thus, please type LGTM into the comment box to accept
9494 a change from Phabricator.
9595
96 Committing a change
97 -------------------
98
99 When committing an LLVM change that has been reviewed using
100 Phabricator, the convention is for the commit message to end with the
101 line:
102
103 ::
104
105 Differential Revision:
106
107 where ```` is the URL for the code review, starting with
108 ``http://llvm-reviews.chandlerc.com/``.
109
110 Note that Arcanist will add this automatically.
111
112 This allows people reading the version history to see the review for
113 context. This also allows Phabricator to detect the commit, close the
114 review, and add a link from the review to the commit.
115
96116 Status
97117 ------
98118