llvm.org GIT mirror llvm / 0527d9e
[WebAssembly] Remove TODO on wasm.extract.exception intrinsic (NFC) Summary: We planned to delete this intrinsic and do custom lowering from `wasm.get.exception`, which has a token argument, to `EXTRACT_EXCEPTION`, a wasm pseudo instruction that simulates popping a value from the wasm stack. To do that, we need to introduce a new `WebAssemblyISD` node for this, which itself is not a problem, but also have to introduce the `WebAssemblyISD` namespace in SelectionDAGBuilder.cpp. I don't think any other targets are doing that in the file. And also putting a target-specific intrinsic in the common file is a little weird too. (All other intrinsic functions in this `visitIntrinsicCall` functions are not target-specific ones. Other target-specific intrinsics are usually handled in `lib/Target/[TargetName]/[TargetName]ISelLowering.cpp`. The reason we can't do this is it has a token argument. Anyway, so I think I prefer the current code with one redundant intrinsic more than adding one more `WebAssemblyISD` node and also introducing the `WebAssemblyISD` namespace into SelectionDAGBuilder.cpp. What do you think? Reviewers: dschuff Subscribers: sbc100, jgravelle-google, sunfish, llvm-commits Differential Revision: https://reviews.llvm.org/D57480 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@352695 91177308-0d34-0410-b5e6-96231b3b80d8 Heejin Ahn 1 year, 2 months ago
1 changed file(s) with 0 addition(s) and 2 deletion(s). Raw diff Collapse all Expand all
5050 [IntrHasSideEffects]>;
5151 // This is the same as llvm.wasm.get.exception except that it does not take a
5252 // token operand. This is only for instruction selection purpose.
53 // TODO Remove this redundant intrinsic and do custom lowering on
54 // int_wasm_get_exception instead
5553 def int_wasm_extract_exception : Intrinsic<[llvm_ptr_ty], [],
5654 [IntrHasSideEffects]>;
5755